Commit 18077b5d3ab for nodejs
commit 18077b5d3ab3d3baf4312eaff5dc0405296e2fdc
Author: Joyee Cheung <joyeec9h3@gmail.com>
Date: Tue Sep 29 11:17:32 2026 +0200
build: do not match v8_libplatform_headers when scraping sources
Otherwise the target contains undefined symbols because there are
only header files in the list.
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/66537
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
diff --git a/tools/v8_gypfiles/v8.gyp b/tools/v8_gypfiles/v8.gyp
index e9e689eea57..ba767e78cb6 100644
--- a/tools/v8_gypfiles/v8.gyp
+++ b/tools/v8_gypfiles/v8.gyp
@@ -1780,7 +1780,7 @@
'v8_libbase',
],
'sources': [
- '<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "\\"v8_libplatform.*?sources = ")',
+ '<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "v8_component.\\"v8_libplatform\\".*?sources = ")',
],
'conditions': [
['component=="shared_library"', {
@@ -1791,10 +1791,10 @@
}],
['v8_use_perfetto==1', {
'sources!': [
- '<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "\\"v8_libplatform.*?v8_use_perfetto.*?sources \\-= ")',
+ '<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "v8_component.\\"v8_libplatform\\".*?v8_use_perfetto.*?sources \\-= ")',
],
'sources': [
- '<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "\\"v8_libplatform.*?v8_use_perfetto.*?sources \\+= ")',
+ '<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "v8_component.\\"v8_libplatform\\".*?v8_use_perfetto.*?sources \\+= ")',
],
'conditions': [
['node_shared_perfetto=="false"', {