Commit 1e5fd22baa for qemu.org
commit 1e5fd22baa208a72c9356d9201f2efc6baa6cded
Author: Daniel P. Berrangé <berrange@redhat.com>
Date: Mon Nov 2 14:28:32 2026 +0000
trace: remove redundant headers from simple trace backend code
The main formatter for .h/.c files for generated trace code
already includes osdep.h and control.h, so it is redundant
for the simple trace backend to add them too.
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-id: 20261102142844.3464712-14-berrange@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
diff --git a/scripts/tracetool/backend/simple.py b/scripts/tracetool/backend/simple.py
index b131e4fc19..e22683c7d2 100644
--- a/scripts/tracetool/backend/simple.py
+++ b/scripts/tracetool/backend/simple.py
@@ -48,9 +48,7 @@ def generate_h_backend_dstate(event, group):
def generate_c_begin(events, group):
- out('#include "qemu/osdep.h"',
- '#include "trace/control.h"',
- '#include "trace/simple.h"',
+ out('#include "trace/simple.h"',
'')
diff --git a/tests/tracetool/all.c b/tests/tracetool/all.c
index 820ddb575b..3b8d4d32d1 100644
--- a/tests/tracetool/all.c
+++ b/tests/tracetool/all.c
@@ -34,8 +34,6 @@ static void trace_testsuite_register_events(void)
trace_event_register_group(testsuite_trace_events);
}
trace_init(trace_testsuite_register_events)
-#include "qemu/osdep.h"
-#include "trace/control.h"
#include "trace/simple.h"
void _simple_trace_test_blah(void *context, const char *filename)
diff --git a/tests/tracetool/simple.c b/tests/tracetool/simple.c
index 820ddb575b..3b8d4d32d1 100644
--- a/tests/tracetool/simple.c
+++ b/tests/tracetool/simple.c
@@ -34,8 +34,6 @@ static void trace_testsuite_register_events(void)
trace_event_register_group(testsuite_trace_events);
}
trace_init(trace_testsuite_register_events)
-#include "qemu/osdep.h"
-#include "trace/control.h"
#include "trace/simple.h"
void _simple_trace_test_blah(void *context, const char *filename)