Commit 25883c7ba8 for wordpress.org
commit 25883c7ba8f371a855ece465f9843ed69dd5c0f5
Author: westonruter <westonruter@git.wordpress.org>
Date: Wed Oct 14 05:14:45 2026 +0000
Code Quality: Remove an always-true check in `_wp_menu_output()`.
Every top-level admin menu item receives at least one class, since the current-item check either adds `current` or `wp-has-current-submenu wp-menu-open` or else adds `wp-not-current-submenu`, so the empty-string fallback for the `class` attribute was unreachable. The only other `ternary.alwaysTrue` occurrence, in `theme-install.php`, was resolved in r64336, so the baseline is now empty and is deleted along with its include in `phpstan.neon.dist`.
Developed in https://github.com/WordPress/wordpress-develop/pull/14264.
Follow-up to r63023, r64336.
Props mukesh27, huzaifaalmesbah.
See #65817.
Built from https://develop.svn.wordpress.org/trunk@64341
git-svn-id: http://core.svn.wordpress.org/trunk@63491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
diff --git a/wp-admin/menu-header.php b/wp-admin/menu-header.php
index 5cced0ceae..27f5575318 100644
--- a/wp-admin/menu-header.php
+++ b/wp-admin/menu-header.php
@@ -111,7 +111,7 @@ function _wp_menu_output( $menu, $submenu, $submenu_as_parent = true ) {
$class[] = esc_attr( $item[4] );
}
- $class = $class ? ' class="' . implode( ' ', $class ) . '"' : '';
+ $class = ' class="' . implode( ' ', $class ) . '"';
$id = ! empty( $item[5] ) ? ' id="' . preg_replace( '|[^a-zA-Z0-9_:.]|', '-', $item[5] ) . '"' : '';
$img = '';
$img_style = '';
diff --git a/wp-includes/version.php b/wp-includes/version.php
index b82c38c52b..c056229e9b 100644
--- a/wp-includes/version.php
+++ b/wp-includes/version.php
@@ -16,7 +16,7 @@
*
* @global string $wp_version
*/
-$wp_version = '7.2-alpha-64340';
+$wp_version = '7.2-alpha-64341';
/**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.