Commit 2589e42f480 for nodejs
commit 2589e42f480e770ee5c137b5d98c7360120d7ee1
Author: Joyee Cheung <joyeec9h3@gmail.com>
Date: Tue Oct 6 16:30:05 2026 +0200
deps: V8: cherry-pick 95626c699ff2
Original commit message:
[objects] Use a generic lambda for gc_retry in BackingStore
gc_retry passes a std::function<bool()> as base::FunctionRef, which
derives the signature from decltype(&Functor::operator()), whose type
is unspecified by the standard, and it fails to compile with
MSVC STL.
Use a generic lambda so FunctionRef binds to the caller's lambda
directly.
Co-Authored-By: StefanStojanovic <stefan.stojanovic@janeasystems.com>
Refs: https://github.com/nodejs/node/pull/61898
Change-Id: I9ce000ed3136942577b1a6da0b890bc48d0f00e5
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8517726
Commit-Queue: Joyee Cheung <joyee@igalia.com>
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#110418}
Refs: https://github.com/v8/v8/commit/95626c699ff2ea251137a1abd4e73ad5be394b9f
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/66601
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
diff --git a/common.gypi b/common.gypi
index 456b6637511..73695cac679 100644
--- a/common.gypi
+++ b/common.gypi
@@ -44,7 +44,7 @@
# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
- 'v8_embedder_string': '-node.6',
+ 'v8_embedder_string': '-node.7',
##### V8 defaults for Node.js #####
diff --git a/deps/v8/src/objects/backing-store.cc b/deps/v8/src/objects/backing-store.cc
index feb9f85096b..74df6b3162c 100644
--- a/deps/v8/src/objects/backing-store.cc
+++ b/deps/v8/src/objects/backing-store.cc
@@ -323,7 +323,7 @@ std::unique_ptr<BackingStore> BackingStore::TryAllocateAndPartiallyCommitMemory(
// For accounting purposes, whether a GC was necessary.
bool did_retry = false;
- auto gc_retry = [&](const std::function<bool()>& fn) {
+ auto gc_retry = [&](const auto& fn) {
if (fn()) return true;
// Collect garbage and retry.
did_retry = true;