Commit 39b975cf7c for qemu.org
commit 39b975cf7c6c869b61ec4907aedfdd3e30144c2b
Author: Richard Henderson <richard.henderson@linaro.org>
Date: Sun Sep 13 22:23:35 2026 -1000
accel: Change AccelOpsClass.update_guest_debug to void
The return value is never used, so drop it.
Reviewed-by: Matt Turner <mattst88@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
diff --git a/accel/hvf/hvf-accel-ops.c b/accel/hvf/hvf-accel-ops.c
index d2276d8513..65db99cd66 100644
--- a/accel/hvf/hvf-accel-ops.c
+++ b/accel/hvf/hvf-accel-ops.c
@@ -227,10 +227,9 @@ static void do_hvf_update_guest_debug(CPUState *cpu, run_on_cpu_data arg)
hvf_arch_update_guest_debug(cpu);
}
-int hvf_update_guest_debug(CPUState *cpu)
+void hvf_update_guest_debug(CPUState *cpu)
{
run_on_cpu(cpu, do_hvf_update_guest_debug, RUN_ON_CPU_NULL);
- return 0;
}
static int hvf_insert_gdbstub_breakpoint(CPUState *cpu, GdbBreakpointType type,
@@ -264,10 +263,7 @@ static int hvf_insert_gdbstub_breakpoint(CPUState *cpu, GdbBreakpointType type,
}
CPU_FOREACH(cpu) {
- err = hvf_update_guest_debug(cpu);
- if (err) {
- return err;
- }
+ hvf_update_guest_debug(cpu);
}
return 0;
}
@@ -304,10 +300,7 @@ static int hvf_remove_gdbstub_breakpoint(CPUState *cpu, GdbBreakpointType type,
}
CPU_FOREACH(cpu) {
- err = hvf_update_guest_debug(cpu);
- if (err) {
- return err;
- }
+ hvf_update_guest_debug(cpu);
}
return 0;
}
diff --git a/accel/kvm/kvm-accel-ops.c b/accel/kvm/kvm-accel-ops.c
index c8e7aa3870..47244d33f7 100644
--- a/accel/kvm/kvm-accel-ops.c
+++ b/accel/kvm/kvm-accel-ops.c
@@ -86,9 +86,9 @@ static bool kvm_cpus_are_resettable(void)
}
#ifdef TARGET_KVM_HAVE_GUEST_DEBUG
-static int kvm_update_guest_debug_ops(CPUState *cpu)
+static void kvm_update_guest_debug_ops(CPUState *cpu)
{
- return kvm_update_guest_debug(cpu, 0);
+ kvm_update_guest_debug(cpu, 0);
}
#endif
diff --git a/include/accel/accel-cpu-ops.h b/include/accel/accel-cpu-ops.h
index f0c7ee7542..af71fd9ab3 100644
--- a/include/accel/accel-cpu-ops.h
+++ b/include/accel/accel-cpu-ops.h
@@ -85,7 +85,7 @@ struct AccelOpsClass {
int64_t (*get_elapsed_ticks)(void);
/* gdbstub hooks */
- int (*update_guest_debug)(CPUState *cpu);
+ void (*update_guest_debug)(CPUState *cpu);
int (*insert_gdbstub_breakpoint)(CPUState *cpu, GdbBreakpointType type,
vaddr addr, vaddr len);
int (*remove_gdbstub_breakpoint)(CPUState *cpu, GdbBreakpointType type,
diff --git a/include/system/hvf_int.h b/include/system/hvf_int.h
index a01691ce17..1b419b5428 100644
--- a/include/system/hvf_int.h
+++ b/include/system/hvf_int.h
@@ -105,7 +105,7 @@ void hvf_arch_remove_all_gdbstub_hw_breakpoints(void);
* Update guest to enable or disable debugging. Per-arch specifics will be
* handled by calling down to hvf_arch_update_guest_debug.
*/
-int hvf_update_guest_debug(CPUState *cpu);
+void hvf_update_guest_debug(CPUState *cpu);
bool hvf_arch_cpu_realize(CPUState *cpu, Error **errp);
uint32_t hvf_arch_get_default_ipa_bit_size(void);