Commit 3bcb08bc1c for qemu.org
commit 3bcb08bc1c7c5b0a166fe65195850251c8714493
Author: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
Date: Tue Aug 4 18:17:40 2026 +0300
scripts/qemugdb: coroutine: Fix '--detailed' description
Both commands claim the coredump is copied before its registers get
patched, but patch_regs() writes to the coredump itself. Describe what
actually happens, so that nobody expects their coredump to be left alone.
Fix a typo in "runing" while at it.
Fixes: 42f3c143c3a0 ("scripts/qemugdb: coroutine: Add option for obtaining detailed trace in coredump")
Signed-off-by: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
Message-ID: <20260804151743.937694-7-andrey.drobyshev@virtuozzo.com>
Tested-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
diff --git a/scripts/qemugdb/coroutine.py b/scripts/qemugdb/coroutine.py
index 4803914dde..9148264de3 100644
--- a/scripts/qemugdb/coroutine.py
+++ b/scripts/qemugdb/coroutine.py
@@ -306,7 +306,7 @@ def bt_jmpbuf(jmpbuf, is_coredump, detailed=False):
# but only works with live sessions.
dump_backtrace_live(regs)
elif detailed:
- # Obtain detailed trace by patching regs in copied coredump
+ # Obtain detailed trace by patching regs in the coredump in place
dump_backtrace_patched(regs)
else:
# Obtain a non-detailed trace by poor man's unwind
@@ -342,9 +342,9 @@ class CoroutineCommand(gdb.Command):
Usage: qemu coroutine COROPTR [--detailed]
Show backtrace for a coroutine specified by COROPTR
- --detailed obtain detailed trace by copying coredump, patching
- regs in it, and runing gdb subprocess to get
- backtrace from the patched coredump
+ --detailed obtain detailed trace by patching regs in the
+ coredump in place, and running gdb subprocess to
+ get backtrace from the patched coredump
""")
def __init__(self):
@@ -380,9 +380,9 @@ class CoroutineBt(gdb.Command):
Usage: qemu bt [--detailed]
- --detailed obtain detailed trace by copying coredump, patching
- regs in it, and runing gdb subprocess to get
- backtrace from the patched coredump
+ --detailed obtain detailed trace by patching regs in the
+ coredump in place, and running gdb subprocess to
+ get backtrace from the patched coredump
""")
def __init__(self):