Commit 3e6347726bf for nodejs
commit 3e6347726bf71ff5b089ad8a6dc403f00d6756c5
Author: Rafael Gonzaga <rafael.nunu@hotmail.com>
Date: Sat Oct 10 11:22:00 2026 -0300
benchmark: fix buffer option in buffer read/write benchmarks
main() read `buf` instead of `buffer`, so every run measured
Buffer.allocUnsafeSlow() even when labeled buffer=fast. Also benchmark
the slow variant and trim the byteLength matrix.
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: https://github.com/nodejs/node/pull/66604
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
diff --git a/benchmark/buffers/buffer-read-with-byteLength.js b/benchmark/buffers/buffer-read-with-byteLength.js
index 4cbe12ef4fe..1f6cfdf1490 100644
--- a/benchmark/buffers/buffer-read-with-byteLength.js
+++ b/benchmark/buffers/buffer-read-with-byteLength.js
@@ -10,14 +10,14 @@ const types = [
];
const bench = common.createBenchmark(main, {
- buffer: ['fast'],
+ buffer: ['fast', 'slow'],
type: types,
n: [1e6],
- byteLength: [1, 2, 3, 4, 5, 6],
+ byteLength: [1, 2, 4, 6],
});
-function main({ n, buf, type, byteLength }) {
- const buff = buf === 'fast' ?
+function main({ n, buffer, type, byteLength }) {
+ const buff = buffer === 'fast' ?
Buffer.alloc(8) :
Buffer.allocUnsafeSlow(8);
const fn = `read${type}`;
diff --git a/benchmark/buffers/buffer-read.js b/benchmark/buffers/buffer-read.js
index 2543db7f5d6..19570a6b924 100644
--- a/benchmark/buffers/buffer-read.js
+++ b/benchmark/buffers/buffer-read.js
@@ -20,13 +20,13 @@ const types = [
];
const bench = common.createBenchmark(main, {
- buffer: ['fast'],
+ buffer: ['fast', 'slow'],
type: types,
n: [1e6],
});
-function main({ n, buf, type }) {
- const buff = buf === 'fast' ?
+function main({ n, buffer, type }) {
+ const buff = buffer === 'fast' ?
Buffer.alloc(8) :
Buffer.allocUnsafeSlow(8);
const fn = `read${type}`;
diff --git a/benchmark/buffers/buffer-write.js b/benchmark/buffers/buffer-write.js
index 25a3a04a130..66ef97fbae0 100644
--- a/benchmark/buffers/buffer-write.js
+++ b/benchmark/buffers/buffer-write.js
@@ -27,7 +27,7 @@ const types = [
];
const bench = common.createBenchmark(main, {
- buffer: ['fast'],
+ buffer: ['fast', 'slow'],
type: types,
n: [1e6],
});
@@ -70,8 +70,8 @@ const byteLength = {
writeIntBE: 6,
};
-function main({ n, buf, type }) {
- const buff = buf === 'fast' ?
+function main({ n, buffer, type }) {
+ const buff = buffer === 'fast' ?
Buffer.alloc(8) :
Buffer.allocUnsafeSlow(8);
const fn = `write${type}`;