Commit 4968fd9777 for bind
commit 4968fd9777ba13c7459c4927b0f81d7303a6183f
Author: Martin Basti <mbasti@isc.org>
Date: Fri Oct 9 19:58:30 2026 +0000
Remove unused private algorithm text helpers
dst_privatedns_fromtext, dns_privatedns_totext, dns_privatedns_format
and their PRIVATEOID counterparts have had no callers since they were
added; their tables are subsets of the one dst_algorithm_fromtext and
dst_algorithm_totext already search, so every call site uses those.
Assisted-by: Claude:claude-fable-5-1
diff --git a/lib/dns/include/dst/dst.h b/lib/dns/include/dst/dst.h
index 9089c630ec..4abff90182 100644
--- a/lib/dns/include/dst/dst.h
+++ b/lib/dns/include/dst/dst.h
@@ -1275,24 +1275,6 @@ dst_algorithm_tosecalg(dst_algorithm_t dst_alg);
* Zero is returned when there is no mapping.
*/
-isc_result_t
-dst_privatedns_fromtext(dst_algorithm_t *algp, isc_textregion_t *source);
-
-isc_result_t
-dns_privatedns_totext(dst_algorithm_t alg, isc_buffer_t *b);
-
-void
-dns_privatedns_format(dst_algorithm_t alg, char *buf, unsigned int size);
-
-isc_result_t
-dst_privateoid_fromtext(dst_algorithm_t *algp, isc_textregion_t *source);
-
-isc_result_t
-dns_privateoid_totext(dst_algorithm_t alg, isc_buffer_t *b);
-
-void
-dns_privateoid_format(dst_algorithm_t alg, char *buf, unsigned int size);
-
dst_algorithm_t
dst_algorithm_fromdata(dns_secalg_t algorithm, unsigned char *data,
unsigned int length);
diff --git a/lib/dns/rcode.c b/lib/dns/rcode.c
index 0ac4578bdd..290d0528f8 100644
--- a/lib/dns/rcode.c
+++ b/lib/dns/rcode.c
@@ -176,8 +176,6 @@ static struct tbl secprotos[] = { SECPROTONAMES };
static struct tbl hashalgs[] = { HASHALGNAMES };
static struct tbl dsdigests[] = { DSDIGESTNAMES };
static struct tbl dsyncschemes[] = { DSYNCSCHEMES };
-static struct tbl privatednss[] = { PRIVATEDNSS SENTINEL };
-static struct tbl privateoids[] = { PRIVATEOIDS SENTINEL };
static struct tbl dstalgorithms[] = { PRIVATEDNSS PRIVATEOIDS SECALGNAMES };
static struct keyflag {
@@ -380,64 +378,6 @@ dns_secalg_format(dns_secalg_t alg, char *cp, unsigned int size) {
}
}
-isc_result_t
-dst_privatedns_fromtext(dst_algorithm_t *dstalgp, isc_textregion_t *source) {
- unsigned int value;
- RETERR(dns_mnemonic_fromtext(&value, source, privatednss, 0));
- *dstalgp = value;
- return ISC_R_SUCCESS;
-}
-
-isc_result_t
-dns_privatedns_totext(dst_algorithm_t alg, isc_buffer_t *target) {
- return dns_mnemonic_totext(alg, target, privatednss);
-}
-
-void
-dns_privatedns_format(dst_algorithm_t alg, char *cp, unsigned int size) {
- isc_buffer_t b;
- isc_region_t r;
- isc_result_t result;
-
- REQUIRE(cp != NULL && size > 0);
- isc_buffer_init(&b, cp, size - 1);
- result = dns_privatedns_totext(alg, &b);
- isc_buffer_usedregion(&b, &r);
- cp[r.length] = 0;
- if (result != ISC_R_SUCCESS) {
- r.base[0] = 0;
- }
-}
-
-isc_result_t
-dst_privateoid_fromtext(dst_algorithm_t *dstalgp, isc_textregion_t *source) {
- unsigned int value;
- RETERR(dns_mnemonic_fromtext(&value, source, privateoids, 0));
- *dstalgp = value;
- return ISC_R_SUCCESS;
-}
-
-isc_result_t
-dns_privateoid_totext(dst_algorithm_t alg, isc_buffer_t *target) {
- return dns_mnemonic_totext(alg, target, privateoids);
-}
-
-void
-dns_privateoid_format(dst_algorithm_t alg, char *cp, unsigned int size) {
- isc_buffer_t b;
- isc_region_t r;
- isc_result_t result;
-
- REQUIRE(cp != NULL && size > 0);
- isc_buffer_init(&b, cp, size - 1);
- result = dns_privateoid_totext(alg, &b);
- isc_buffer_usedregion(&b, &r);
- cp[r.length] = 0;
- if (result != ISC_R_SUCCESS) {
- r.base[0] = 0;
- }
-}
-
isc_result_t
dns_secproto_fromtext(dns_secproto_t *secprotop, isc_textregion_t *source) {
unsigned int value;