Commit 5741b0ed045 for nodejs
commit 5741b0ed0459d490b8fe9508266b1b3d77500138
Author: Antoine du Hamel <duhamelantoine1995@gmail.com>
Date: Fri Oct 23 12:35:37 2026 +0200
build: error on incompatible quic configure flags
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/66893
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
diff --git a/configure.py b/configure.py
index be61c6d95f6..42a1e33e9df 100755
--- a/configure.py
+++ b/configure.py
@@ -2436,15 +2436,14 @@ def configure_ffi(o):
def configure_quic(o):
if options.experimental_quic and options.without_ssl:
- warn('--experimental-quic is incompatible with --without-ssl')
- o['variables']['node_use_quic'] = b(options.experimental_quic and
- not options.without_ssl)
+ error('--experimental-quic is incompatible with --without-ssl')
+ o['variables']['node_use_quic'] = b(options.experimental_quic)
if not options.experimental_quic:
for lib in ['nghttp3', 'ngtcp2']:
shared_lib = 'shared_' + lib
if getattr(options, shared_lib):
- warn(f'--shared-{lib} requires --experimental-quic')
+ error(f'--shared-{lib} requires --experimental-quic')
return
configure_library('nghttp3', output, pkgname='libnghttp3')
diff --git a/tools/nix/non-v8-deps-mock.nix b/tools/nix/non-v8-deps-mock.nix
index 1d00810436a..5275c829767 100644
--- a/tools/nix/non-v8-deps-mock.nix
+++ b/tools/nix/non-v8-deps-mock.nix
@@ -18,13 +18,14 @@ let
"libbrotlienc"
];
cares = [ "libcares" ];
- gtest = [ "gtest" ];
+ gtest = [
+ "gtest"
+ "gtest_main"
+ ];
hdr-histogram = [ "hdr_histogram" ];
merve = [ "merve" ];
nbytes = [ "nbytes" ];
nghttp2 = [ "libnghttp2" ];
- nghttp3 = [ "libnghttp3" ];
- ngtcp2 = [ "libngtcp2" ];
uvwasi = [ "uvwasi" ];
zstd = [ "libzstd" ];
};