Commit 6cf05e7ddcd for nodejs
commit 6cf05e7ddcd42591c9bf9caacbf0f6d8c2af8694
Author: Joyee Cheung <joyeec9h3@gmail.com>
Date: Thu May 21 04:58:27 2026 +0200
src: fix external reference registration for new CFunction lifetime
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/65161
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
diff --git a/src/node_external_reference.h b/src/node_external_reference.h
index 3a2d4176715..abdf6a36cbc 100644
--- a/src/node_external_reference.h
+++ b/src/node_external_reference.h
@@ -43,9 +43,6 @@ class ExternalReferenceRegistry {
// and the corresponding CFunctionInfo.
void Register(const v8::CFunction& c_func) {
RegisterT(&c_func);
- // TODO(joyeecheung): remove below when V8 14.8 lands.
- RegisterT(c_func.GetAddress());
- RegisterT(c_func.GetTypeInfo());
}
// This can be called only once.