Commit a232998e0de for nodejs
commit a232998e0de60db23769571dcf981beb4fd4f176
Author: Antoine du Hamel <duhamelantoine1995@gmail.com>
Date: Thu Oct 22 10:18:19 2026 +0200
tools: add `--error-on-warn` configure flag in `test-shared.yml`
Given that this workflow compiles V8 and other libs separately, that
would allow us to detect any Node.js-specific warning that needs to be
addressed.
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/66751
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
diff --git a/tools/nix/ci-shell.nix b/tools/nix/ci-shell.nix
index 07dc2299f41..c46d0d68c02 100644
--- a/tools/nix/ci-shell.nix
+++ b/tools/nix/ci-shell.nix
@@ -9,6 +9,10 @@ args@{
loadJSBuiltinsDynamically = false;
devTools = [ ];
benchmarkTools = [ ];
+ extraConfigFlags = [
+ "--debug-node"
+ "--error-on-warn"
+ ];
}
// pkgs.lib.optionalAttrs pkgs.stdenv.hostPlatform.isDarwin (
# Disable optional features on Darwin for coverage and faster CI.
@@ -20,6 +24,7 @@ args@{
// {
withSSL = true; # no-SSL coverage is ensured by Jenkins
extraConfigFlags = [
+ "--error-on-warn"
"--without-inspector"
"--without-node-options"
];