Commit d4787a60a7 for bind
commit d4787a60a75d0540c3c161697bc591e22b2bb2a9
Author: Martin Basti <mbasti@isc.org>
Date: Mon Sep 7 17:29:30 2026 +0000
Size dst_algorithm_format buffers with DST_ALG_FORMATSIZE
A few pre-existing dst_algorithm_format() callers sized their buffers
with a literal DNS_NAME_FORMATSIZE. Use DST_ALG_FORMATSIZE so the
algorithm buffers follow the macro if it ever diverges.
Assisted-by: Claude:claude-fable-5
diff --git a/bin/dnssec/dnssectool.c b/bin/dnssec/dnssectool.c
index bb8d12d5e3..3c8f902985 100644
--- a/bin/dnssec/dnssectool.c
+++ b/bin/dnssec/dnssectool.c
@@ -122,7 +122,7 @@ version(const char *name) {
void
sig_format(dns_rdata_rrsig_t *sig, char *cp, unsigned int size) {
char namestr[DNS_NAME_FORMATSIZE];
- char algstr[DNS_NAME_FORMATSIZE];
+ char algstr[DST_ALG_FORMATSIZE];
dst_algorithm_t algorithm = dst_algorithm_fromdata(
sig->algorithm, sig->signature, sig->siglen);
diff --git a/lib/dns/dst_api.c b/lib/dns/dst_api.c
index d497be8be5..a8487685fe 100644
--- a/lib/dns/dst_api.c
+++ b/lib/dns/dst_api.c
@@ -1331,7 +1331,7 @@ dst_key_setflags(dst_key_t *key, uint32_t flags) {
void
dst_key_format(const dst_key_t *key, char *cp, unsigned int size) {
char namestr[DNS_NAME_FORMATSIZE];
- char algstr[DNS_NAME_FORMATSIZE];
+ char algstr[DST_ALG_FORMATSIZE];
dst_algorithm_t algorithm = dst_key_alg(key);
dns_name_format(dst_key_name(key), namestr, sizeof(namestr));
diff --git a/lib/dns/kasp.c b/lib/dns/kasp.c
index 68028a6ae0..cd4e8cdfc1 100644
--- a/lib/dns/kasp.c
+++ b/lib/dns/kasp.c
@@ -549,7 +549,7 @@ dns_kasp_key_format(dns_kasp_key_t *key, char *cp, unsigned int size) {
REQUIRE(key != NULL);
REQUIRE(cp != NULL);
- char algstr[DNS_NAME_FORMATSIZE];
+ char algstr[DST_ALG_FORMATSIZE];
bool csk = dns_kasp_key_ksk(key) && dns_kasp_key_zsk(key);
const char *rolestr = (csk ? "csk"
: (dns_kasp_key_ksk(key) ? "ksk" : "zsk"));
diff --git a/lib/dns/zone.c b/lib/dns/zone.c
index ba3dd34ff3..93db1198b8 100644
--- a/lib/dns/zone.c
+++ b/lib/dns/zone.c
@@ -5571,7 +5571,7 @@ del_sigs(dns_zone_t *zone, dns_db_t *db, dns_dbversion_t *ver, dns_name_t *name,
*/
if (zone->log_key_expired_timer <= now) {
char origin[DNS_NAME_FORMATSIZE];
- char algbuf[DNS_NAME_FORMATSIZE];
+ char algbuf[DST_ALG_FORMATSIZE];
dns_name_format(&zone->origin, origin,
sizeof(origin));
dst_algorithm_format(algorithm, algbuf,