Commit d782ae67b6f for nodejs
commit d782ae67b6f2ea2fb896c5d1d7d9a62bba3c2584
Author: Kyungrae Kang <148605113+kyungrae2002@users.noreply.github.com>
Date: Wed Sep 30 22:30:27 2026 +0900
sqlite: use cached strings for property keys
Signed-off-by: Kyungrae Kang <kyungrae2002@gmail.com>
Assisted-by: Codex
PR-URL: https://github.com/nodejs/node/pull/65902
Reviewed-By: Anna Henningsen <anna@addaleax.net>
diff --git a/src/node_sqlite.cc b/src/node_sqlite.cc
index a243ec49c4d..f488a5e7d88 100644
--- a/src/node_sqlite.cc
+++ b/src/node_sqlite.cc
@@ -2197,9 +2197,7 @@ void Database::Prepare(const FunctionCallbackInfo<Value>& args) {
Local<Object> options = args[1].As<Object>();
Local<Value> return_arrays_v;
- if (!options
- ->Get(env->context(),
- FIXED_ONE_BYTE_STRING(env->isolate(), "returnArrays"))
+ if (!options->Get(env->context(), env->return_arrays_string())
.ToLocal(&return_arrays_v)) {
return;
}
@@ -2214,9 +2212,7 @@ void Database::Prepare(const FunctionCallbackInfo<Value>& args) {
}
Local<Value> read_big_ints_v;
- if (!options
- ->Get(env->context(),
- FIXED_ONE_BYTE_STRING(env->isolate(), "readBigInts"))
+ if (!options->Get(env->context(), env->read_bigints_string())
.ToLocal(&read_big_ints_v)) {
return;
}
@@ -2231,10 +2227,7 @@ void Database::Prepare(const FunctionCallbackInfo<Value>& args) {
}
Local<Value> allow_bare_named_params_v;
- if (!options
- ->Get(env->context(),
- FIXED_ONE_BYTE_STRING(env->isolate(),
- "allowBareNamedParameters"))
+ if (!options->Get(env->context(), env->allow_bare_named_params_string())
.ToLocal(&allow_bare_named_params_v)) {
return;
}
@@ -2250,10 +2243,7 @@ void Database::Prepare(const FunctionCallbackInfo<Value>& args) {
}
Local<Value> allow_unknown_named_params_v;
- if (!options
- ->Get(env->context(),
- FIXED_ONE_BYTE_STRING(env->isolate(),
- "allowUnknownNamedParameters"))
+ if (!options->Get(env->context(), env->allow_unknown_named_params_string())
.ToLocal(&allow_unknown_named_params_v)) {
return;
}
@@ -5364,10 +5354,8 @@ static void Initialize(Local<Object> target,
db_tmpl,
FIXED_ONE_BYTE_STRING(isolate, "isTransaction"),
Database::IsTransactionGetter);
- SetSideEffectFreeGetter(isolate,
- db_tmpl,
- FIXED_ONE_BYTE_STRING(isolate, "limits"),
- Database::LimitsGetter);
+ SetSideEffectFreeGetter(
+ isolate, db_tmpl, env->limits_string(), Database::LimitsGetter);
Local<String> sqlite_type_key = FIXED_ONE_BYTE_STRING(isolate, "sqlite-type");
Local<v8::Symbol> sqlite_type_symbol =
v8::Symbol::For(isolate, sqlite_type_key);