Commit e067d9872a for openssl.org

commit e067d9872a73efc397c45547145cc5d30cd85417
Author: Eugene Syromiatnikov <esyr@openssl.org>
Date:   Mon Sep 21 10:01:32 2026 +0200

    test/cmp_hdr_test.c: check X509_NAME_add_entry_by_txt() result

    Check X509_NAME_add_entry_by_txt() result (wrapped in X509_NAME_ADD()
    macro), as it may fail.

    Reported by Coverity as unchecked return value, CID 1701601, 1701602,
    and 170604.

    Resolves: https://scan5.scan.coverity.com/#/project-view/65248/10222?selectedIssue=1701601
    Resolves: https://scan5.scan.coverity.com/#/project-view/65248/10222?selectedIssue=1701602
    Resolves: https://scan5.scan.coverity.com/#/project-view/65248/10222?selectedIssue=1701604
    Complements: 4dde554c6ae2 "chunk 5 of CMP contribution to OpenSSL"
    Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org>
    Reviewed-by: Nikola Pajkovsky <nikolap@openssl.org>
    Reviewed-by: Norbert Pocs <norbertp@openssl.org>
    Merge-date: Fri Sep 25 11:43:52 2026
    Merged-from: https://github.com/openssl/openssl/pull/32901

diff --git a/test/cmp_hdr_test.c b/test/cmp_hdr_test.c
index 89a1c9c449..2ee01f3cb5 100644
--- a/test/cmp_hdr_test.c
+++ b/test/cmp_hdr_test.c
@@ -78,7 +78,8 @@ static int execute_HDR_get0_senderNonce_test(CMP_HDR_TEST_FIXTURE *fixture)
     if (!TEST_ptr(sender))
         goto err;

-    X509_NAME_ADD(sender, "CN", "A common sender name");
+    if (!TEST_true(X509_NAME_ADD(sender, "CN", "A common sender name")))
+        goto err;
     if (!TEST_int_eq(OSSL_CMP_CTX_set1_subjectName(fixture->cmp_ctx, sender),
             1))
         goto err;
@@ -113,7 +114,8 @@ static int execute_HDR_set1_sender_test(CMP_HDR_TEST_FIXTURE *fixture)
     if (!TEST_ptr(x509name))
         goto err;

-    X509_NAME_ADD(x509name, "CN", "A common sender name");
+    if (!TEST_true(X509_NAME_ADD(x509name, "CN", "A common sender name")))
+        goto err;
     if (!TEST_int_eq(ossl_cmp_hdr_set1_sender(fixture->hdr, x509name), 1))
         goto err;

@@ -148,7 +150,8 @@ static int execute_HDR_set1_recipient_test(CMP_HDR_TEST_FIXTURE *fixture)
     if (!TEST_ptr(x509name))
         goto err;

-    X509_NAME_ADD(x509name, "CN", "A common recipient name");
+    if (!TEST_true(X509_NAME_ADD(x509name, "CN", "A common recipient name")))
+        goto err;
     if (!TEST_int_eq(ossl_cmp_hdr_set1_recipient(fixture->hdr, x509name), 1))
         goto err;