Commit ea6ec93b2f6 for nodejs
commit ea6ec93b2f6504a757660891402872897a2db81a
Author: Antoine du Hamel <duhamelantoine1995@gmail.com>
Date: Tue Oct 13 17:25:12 2026 +0200
build,test: enable temporal support on no-ICU and system-ICU builds
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/66697
Refs: https://github.com/nodejs/node/pull/65992
Refs: https://github.com/nodejs/node/pull/66183
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
diff --git a/configure.py b/configure.py
index e38dd91cdb9..a3769ff2d87 100755
--- a/configure.py
+++ b/configure.py
@@ -2264,15 +2264,6 @@ def configure_v8(o, configs):
o['variables']['v8_enable_external_code_space'] = 1 if options.enable_pointer_compression else 0
o['variables']['v8_enable_31bit_smis_on_64bit_arch'] = 1 if options.enable_pointer_compression else 0
o['variables']['v8_enable_extensible_ro_snapshot'] = 0
- # TODO(richardlau): Temporal objects in V8 currently reference a private
- # ICU header file and fail to compile with shared ICU or no ICU. For now,
- # if auto-detecting, warn and disable Temporal in those cases.
- # Refs: https://github.com/nodejs/node/issues/62676
- if (not options.v8_disable_temporal_support and not options.v8_enable_temporal_support):
- match options.with_intl:
- case 'none':
- warn('Temporal support disabled when compiling without ICU')
- options.v8_disable_temporal_support = True
o['variables']['v8_enable_temporal_support'] = 0 if options.v8_disable_temporal_support else 1
o['variables']['v8_trace_maps'] = 1 if options.trace_maps else 0
o['variables']['v8_use_perfetto'] = 1 if options.with_perfetto else 0
diff --git a/test/parallel/test-temporal-with-zoneinfo.js b/test/parallel/test-temporal-with-zoneinfo.js
index 0ff8a4f0012..7ca806bd803 100644
--- a/test/parallel/test-temporal-with-zoneinfo.js
+++ b/test/parallel/test-temporal-with-zoneinfo.js
@@ -6,13 +6,9 @@ if (!common.hasTemporal) {
common.skip('Temporal is not enabled');
}
-// TODO(legendecas): bundle zoneinfo data for small ICU and without ICU builds.
-if (!common.hasFullICU) {
- common.skip('Time zone support unavailable when not built with full ICU');
-}
-// TODO(aduh95): fix zoneinfo support with system-icu.
-if (process.config.variables.icu_system) {
- common.skip('Time zone support unavailable on --with-intl=system-icu builds');
+// TODO(legendecas): bundle zoneinfo data for small ICU.
+if (globalThis.Intl && !common.hasFullICU) {
+ common.skip('Time zone support unavailable when built with small ICU');
}
// Use globalThis.Temporal to workaround linter complaints.