Commit e713336e3c for openssl.org
commit e713336e3c60c318551fade1ea5f97dc78d2276d
Author: Jakub Zelenka <jakub.zelenka@openssl.foundation>
Date: Sat Aug 29 12:31:08 2026 +0200
apps: fix dsa app exit status on option parsing errors
The dsa app set ret to 0 before printing the option parsing error,
resulting in a successful exit status for invalid options. All other
apps keep the initial error status in this case, so drop the errant
assignment to make dsa fail as expected.
Assisted-by: Claude:claude-fable-5
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Daniel Kubec <kubec@openssl.foundation>
Merge-date: Wed Sep 16 08:48:56 2026
Merged-from: https://github.com/openssl/openssl/pull/32590
diff --git a/apps/dsa.c b/apps/dsa.c
index 95a1b432cc..185465ba19 100644
--- a/apps/dsa.c
+++ b/apps/dsa.c
@@ -106,7 +106,6 @@ int dsa_main(int argc, char **argv)
case OPT_EOF:
case OPT_ERR:
opthelp:
- ret = 0;
BIO_printf(bio_err, "%s: Use -help for summary.\n", prog);
goto end;
case OPT_HELP: